A modern dog that lives in an house and has no real job should not be fat. I like to think that you should see some rib, but when the spine is visible / sticking out you take it to far.